[ossec-dev] Re: use stack protector on never gcc versions that support it

["Daniel Cid" <dcid@xxxxxxxxx>]

Hi Jeff,

Your site has been down for a while (tried to access it yesterday and
today). Do you mind
sending the patch attached to us (or turning the power on there :)?

Thanks,

--
Daniel B. Cid
dcid ( at ) ossec.net

On 8/15/07, Jeff Schroeder <jeffschroed@xxxxxxxxx> wrote:
>
> On Aug 15, 5:22 pm, "Daniel Cid" <d...@xxxxxxxxx> wrote:
> > Hi Jeff,
> >
> > Thanks for the patch, it is very good. I just found one small issue with it.
> >
> > +#if defined(__GNUC__) && (__GNUC__ >= 4) && (__GNUC_MINOR__ >= 1) && \
> > +    (__GNUC_PATCHLEVEL__ >= 2)
> >
> > If someone has gcc 4.2.1 or 4.3.0 the "ifdef" is not going to match
> > (because of patch
> > level). We need at least three checks:
> >
> > (__GNUC__ == 4) && (__GNUC_MINOR__ == 1) &&  (__GNUC_PATCHLEVEL__ >= 2)
> >
> > OR
> >
> > (__GNUC__ == 4) && (__GNUC_MINOR__ >= 2)
> >
> > OR
> >
> > (__GNUC__ >= 5)
> >
> > Whatd do you think? Agreed?
>
> Very good point Daniel, here is an updated patch:
> http://www.digitalprognosis.com/opensource/patches/ossec-stack-protector2.patch
>
> The only difference is that the logic has been updated per your
> suggestion.
>
>